[SCM] CTDB repository - branch master updated - ctdb-2.4-48-g713c9ec

[Jeremy Allison]

On Fri, Sep 27, 2013 at 07:49:00PM +1000, Amitay Isaacs wrote:
> Hi Jeremy,
> >
> > Does the server handle signals ? If so it's possible
> > that the read here if it's on a UNIX domain socket
> > may be interrrupted by a signal handler and return
> > EINTR. It can be safely restarted and isn't an
> > error.
> >
> >
> This particular read is from a pipe between the traverse child and ctdb
> daemon.  Not really a unix domain socket.

Reads/writes on pipes are still slow system calls that can be interruped
by a signal. I think you need something like sys_read() here.

> > > +             write(h->fd[1], &res, sizeof(res));
> >
> > No check on the return of the write call...

Ping - you need to check the write call return (always :-).

Jeremy.