[PATCH] Stop use after free

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Sep 25 08:48:42 MDT 2013


On Wed, Sep 25, 2013 at 04:16:47PM +1000, Alistair Leslie-Hughes wrote:
> Hi,
> 
> The reply_arg variable can be use after it has been free. This is
> just a copy from the source4 version.
> 
> Should fix
> https://bugzilla.samba.org/show_bug.cgi?id=10087

While this looks good, it does fix two things. Why don't you
just talloc_strdup session_info->unix_info->unix_name to
state->gensec_state? Is session_info->unix_info->unix_name
something different from the talloc_asprintf args?

Trying to understand it :-)

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

*****************************************************************
visit us on it-sa:IT security exhibitions in Nürnberg, Germany
October 8th - 10th 2013, hall 12, booth 333
free tickets available via code 270691 on: www.it-sa.de/gutschein
******************************************************************


More information about the samba-technical mailing list