FSMO fails to transfer

[Pavel Herrmann]

Hello again

On Monday 23 of September 2013 02:08:28 Pavel Herrmann wrote:
> ...
>     return self.run(*args, **kwargs)
>   File "/usr/lib64/python2.7/site-packages/samba/netcmd/fsmo.py", line 160,
> in run
>     self.seize_role(role, samdb, force)
>   File "/usr/lib64/python2.7/site-packages/samba/netcmd/fsmo.py", line 126,
> in seize_role
>     transfer_role(self.outf, role, samdb)
>   File "/usr/lib64/python2.7/site-packages/samba/netcmd/fsmo.py", line 53,
> in transfer_role
>     samdb.modify(m)

this seems to be a bug in fsmo.py. specifically the line 53 (reading 
"samdb.modify(m)") should not be present (it is not present in other if-
blocks, but it is present again right after them).

as far as I can see the effect of this line is that
A) the modify() is possibly called twice (not sure it matters, though)
B) a different catch-block is used, resulting in this behaviour (failure in 
transfer means death, not fallback to seize)

regards
Pavel Herrmann