[PATCH] Fix a typo that causes Windows DENY ACL mapping to POSIX ACLs to fail.

[Michael Adam]

Pushed to autobuild.

Cheers - Michael

On 2013-09-20 at 18:20 -0700, Jeremy Allison wrote:
> Found and fixed by an OEM, as it was breaking their
> product. It's a pretty obvious fix.
> 
> I created a bug for it as it affects 4.0.next and
> 4.1.0:
> 
> https://bugzilla.samba.org/show_bug.cgi?id=10162
> 
> Can I get a second Team review and fix ?
> 
> Thanks,
> 
> Jeremy.

> >From 7e6f35080ce5faab4b3557d911bf18ead905d4cc Mon Sep 17 00:00:00 2001
> From: Daniel Liberman <danielvl at gmail.com>
> Date: Thu, 19 Sep 2013 20:28:33 -0300
> Subject: [PATCH] Fix bug 10162 - POSIX ACL mapping failing when setting DENY
>  ACE's from Windows.
> 
> Fix for ACL problem - not accepting DENY. Code was checking for pointer and not for content.
> 
> Reviewed-by: Jeremy Allison <jra at samba.org>
> ---
>  source3/smbd/posix_acls.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source3/smbd/posix_acls.c b/source3/smbd/posix_acls.c
> index 3b9be9d..ad1431d 100644
> --- a/source3/smbd/posix_acls.c
> +++ b/source3/smbd/posix_acls.c
> @@ -1808,7 +1808,7 @@ static bool add_current_ace_to_acl(files_struct *fsp, struct security_ace *psa,
>  		if (current_ace->attr == ALLOW_ACE)
>  			*got_file_allow = True;
>  
> -		if ((current_ace->attr == DENY_ACE) && got_file_allow) {
> +		if ((current_ace->attr == DENY_ACE) && *got_file_allow) {
>  			DEBUG(0,("add_current_ace_to_acl: malformed "
>  				 "ACL in file ACL ! Deny entry after "
>  				 "Allow entry. Failing to set on file "
> -- 
> 1.7.9.5
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130921/ee06a120/attachment.pgp>