[PATCH] Add tests for our NFSv4 ACL code

Abhidnya S Joshi achirmul at in.ibm.com
Wed Sep 18 12:34:47 CEST 2013


Hi Andrew,

This is related to the NFSv4 acl work which Alexander Werth completed long 
back. Attached are the patches for inheritance test  + extra user added in 
selftest framework.
Please let me know your comments.



Thanks and Regards
Abhidnya



From:   Andrew Bartlett <abartlet at samba.org>
To:     Abhidnya S Joshi/India/IBM at IBMIN, 
Cc:     samba-technical at lists.samba.org
Date:   04/26/2013 01:21 PM
Subject:        Re: [PATCH] Add tests for our NFSv4 ACL code



On Wed, 2013-04-24 at 17:55 +0530, Abhidnya S Joshi wrote:
> Hi Andrew,
> 
> Thanks for the review comments. While I take care of these, I would like 

> to have one more test which checks inheritance for nfs4:mode 
> specialcreator. This test fails currently for mode special and would 
pass 
> with bug 9467 fix. 
> 
> I have used --extra-user torture option to test correct inheritance and 
> avoid use of any well-knowns/builtins to avoid any further different 
> failures other than basic inheritance. However I am not sure if this 
will 
> work in selftest environment. Please let me know your views on use of 
> --extra-user option. (Existing inheritance test tries to test multiple 
> things except the behavior which new test checks)

To use the extra user, you will need to find one that already exists in
the test environment.  For example, you could test against the s3member
environment, and use --extra-user=$DOMAIN\\$DC_USERNAME%$DC_PASSWORD to
test against the domain administrator and the local administrator.

I don't recommend trying to use the machine account, as you may have
seen I had great trouble because it's password changes. 

Otherwise, you main option is to add another user in the test
environment setup, for example like the 'pdbtest' user in
selftest/target/Samba3.pm (but in this case you would also need to give
it a password). 

Hopefully these give you some good options, or you could use the test
as-is, but change it to run in the plugin_s4_dc environment, where the
authenticated user SID should resolve to a GID.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-Add-torture-test-for-nfs4-acl-inheritance.patch
Type: application/octet-stream
Size: 6276 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130918/75053bb4/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s3-Adding-extra-user-to-selftest-framework-for-tortu.patch
Type: application/octet-stream
Size: 5558 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130918/75053bb4/attachment-0001.obj>


More information about the samba-technical mailing list