[PATCH] selftest/s3: test with FS applicable VFS modules

Andrew Bartlett abartlet at samba.org
Wed Sep 18 03:44:46 CEST 2013

On Tue, 2013-09-17 at 11:30 -0700, David Disseldorp wrote:
> Hi Michael,
> On Tue, 17 Sep 2013 20:00:55 +0200
> Michael Adam <obnox at samba.org> wrote:
> > Hi David,
> > 
> > this looks like a very good thing and a clean patch!
> > 
> > The only concern I have is that I am not 100% certain
> > whether we should change all our test targets based on
> > host setup or whether we should add a separate target
> > to test host-/fs-specific features.
> > 
> > What do others think?
> Thanks for the feedback Michael. I'm also curious to hear what others
> think.
> My main motivation for the change is the ability to quickly deploy a
> test system with Btrfs (E.g. in the build farm) and ensure that all
> available features (compression and enhanced server-side copy) are
> covered during selftest.

I think I would prefer a dynamic knownfail, and always run the same
tests, as well as running them once using the fallbacks and once using
the fs-specific module (ie different shares). 

I'm very happy to look at and talk about things however.  

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list