[SCM] Samba Shared Repository - branch master updated

Kai Blin kai at samba.org
Thu Sep 12 11:23:50 CEST 2013

On 2013-09-12 11:13, Michael Adam wrote:
> On 2013-09-12 at 10:27 +0200, Kai Blin wrote:
>> Again, while I currently don't have a problem, my original worry
>> remains: Having a mandatory review policy will divide the developer team
>> into the people working on popular areas and the people working on areas
>> nobody really cares about. The voluntary review model we currently have
>> avoids this.
> I don't quite see how a voluntary model that all adhere to
> does not do this when a mandatory one does.

Because a voluntary model gives you the option of getting your code in
even if nobody cares.

> My mail was just triggered by one detail where the system does
> not work, namely it does not catch failure to add tags ;-)

Which apparently happens about once every 2772 commits. We can probably
live with that.


Kai Blin
Worldforge developer http://www.worldforge.org/
Wine developer http://wiki.winehq.org/KaiBlin
Samba team member http://www.samba.org/samba/team/

More information about the samba-technical mailing list