[SCM] Samba Shared Repository - branch master updated
mat at samba.org
Thu Sep 12 09:32:25 CEST 2013
On 09/11/2013 09:43 PM, Kai Blin wrote:
> On 11/09/13 22:37, Michael Adam wrote:
>> On 2013-09-11 at 10:18 +0200, Volker Lendecke wrote:
>>> On Wed, Sep 11, 2013 at 10:16:02AM +0200, Volker Lendecke wrote:
>>> Gna. Pushed from the wrong tree. This was meant to carry
>>> Reviewed-by: Jeremy Allison <jra at samba.org>
>>> tags. Push a revert?
>> I'd say there is no point. It is in the tree and you would
>> have to get review for the revert first... ;) The important
>> point is that review has in fact happened.
>> This would not have happened, if we had installed a
>> mechanism that would reject a push if one at least of
>> the commits does not contain at least two signoff/review
>> tags by team members... (Hint, hint... ;-)
> If that was to check if I was still reading this list, I am. :)
> And my opinion on this is the same as it was the last time we
> discussed this. Unless of course we invite nobody.gave.adamn at samba.org
> into the team to do reviews. ;)
I do agree with Kai !
More information about the samba-technical