[PATCH] gencache: Avoid a duplicate call to string_term_tdb_data

[Volker Lendecke]

Hi!

Trivial optimization, please review&push!

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

*****************************************************************
visit us on it-sa:IT security exhibitions in Nürnberg, Germany
October 8th - 10th 2013, hall 12, booth 333
free tickets available via code 270691 on: www.it-sa.de/gutschein
******************************************************************
-------------- next part --------------
>From 42526212e15f8584ee4616ed82a372ddcf681473 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Sun, 8 Sep 2013 13:29:33 +0200
Subject: [PATCH] gencache: Avoid a duplicate call to string_term_tdb_data

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source3/lib/gencache.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/source3/lib/gencache.c b/source3/lib/gencache.c
index 2c5e9ab..835f5e1 100644
--- a/source3/lib/gencache.c
+++ b/source3/lib/gencache.c
@@ -443,21 +443,19 @@ bool gencache_parse(const char *keystr,
 		    void *private_data)
 {
 	struct gencache_parse_state state;
-	TDB_DATA key;
+	TDB_DATA key = string_term_tdb_data(keystr);
 	int ret;
 
 	if (keystr == NULL) {
 		return false;
 	}
-	if (tdb_data_cmp(string_term_tdb_data(keystr),
-			 last_stabilize_key()) == 0) {
+	if (tdb_data_cmp(key, last_stabilize_key()) == 0) {
 		return false;
 	}
 	if (!gencache_init()) {
 		return false;
 	}
 
-	key = string_term_tdb_data(keystr);
 	state.parser = parser;
 	state.private_data = private_data;
 
-- 
1.7.9.5