[PATCH]: talloc_pooled_object patchset

David Illescas dillescas at wurldtech.com
Sat Sep 7 02:49:22 CEST 2013

Okay. Attempt number three. Robin would like an all-nil param to match 
to true, which is effectively a matcher for the tcp protocol.

local params = {
     -- integer
     sport = nil,
     -- integer
     dport = nil,
     -- string
     protocol = nil

function match(msg)
     local is_match = true;

     if params.sport then is_match = is_match and params.sport == 
msg.sport end
     if params.dport then is_match = is_match and params.dport == 
msg.dport end

     return params.protocol ~= nil and msg.protocol == params.protocol 
and is_match

David Illescas

On 13-09-06 04:10 PM, Jeremy Allison wrote:
> On Mon, Aug 26, 2013 at 07:11:13PM +0200, Stefan (metze) Metzmacher wrote:
>> Hi Jeremy,
>> hi Volker,
>>> On Thu, Aug 22, 2013 at 09:00:42PM -0700, Jeremy Allison wrote:
>>>> Ok - here is a patchset I think is pushable to
>>>> master if you agree :-).
>>>> I took the liberty of adding your 'Signed-off-by'
>>>> line as well as my 'Reviewed-by' tag.
>>>> Turns out the only 3 changes needed to make this
>>>> patchset valgrind-clean from my posted changes
>>>> were the following :
>>> Thanks a lot for fixing those! Before pushing, I would like
>>> metze to also give his blessing to the patchset. He will be
>>> available on monday again, so I will ping him then.
>> I reviewed the patches, I'm almost happy with them.
>> I just found a few minor things we need to discuss/fix.
>> The attached patches have TODO comments in their commit message.
> Ok, here is a rebased and partly rewritten patchset
> on top of the fixes I put into talloc to make the
> memlimit code work with talloc pools.
> It's valgrind-clean and is careful to keep the memlimit
> code working. It also contains the squashes you requested
> squashed, and the TODO's you wanted done fixing.
> Please review and push (or give me a +1 :-) if you're
> happy with it.
> Cheers,
> 	Jeremy

More information about the samba-technical mailing list