[PATCH] Fix Bug 5917 - Samba does not work on site with Read Only Domain Controller

[Jeremy Allison]

On Wed, Sep 04, 2013 at 12:45:06PM -0700, Jeremy Allison wrote:
> On Wed, Sep 04, 2013 at 09:35:43PM +0200, Volker Lendecke wrote:
> > On Wed, Sep 04, 2013 at 10:42:26AM -0700, Jeremy Allison wrote:
> > > It leaves gencache_get() as a mixed interface, sometimes
> > > returning a talloced value, sometimes a malloced.
> > 
> > I know. We could rename gencache_get to gencache_get_malloc
> > in one run and make gencache_get always talloc.
> 
> That works. But I'm also working on fixing the code
> so that gencache_get() always uses talloc, and fixing
> the callers :-).

FYI. In doing this I've found at least one memory
leak where we aren't freeing the return from gencache_get() :-).

Jeremy.