[PATCH] Fix Bug 5917 - Samba does not work on site with Read Only Domain Controller

[Richard Sharpe]

On Tue, Sep 3, 2013 at 12:37 PM, Jeremy Allison <jra at samba.org> wrote:
> Fix inspired by a patch created by hemanth.thummala at gmail.com
> on the bug.
>
> From his comment on the bug:
>
> "I am able to figure out the root cause. Looks like we are not doing domain
> level DC discovery if we find few DCs at site level.
>
> In the code , initially discover_dc_dns() will find DCs at site level first.
> And if the number of DCs returned from site is zero then it will try to fetch
> the DCs at domain level(by setting site_name to NULL).
>
> DC validation is actually done later in process_dc_dns(). There we realize that
> the list of DCs are not valid for domain join as in this case they are not
> writable."
>
> This patchset fixes the problem in a cleaner
> way by creating a wrapper function for
> dsgetdcname() that does the sitename
> manipulation that callers expect when
> the pass in NULL or "" as the sitename,
> yet still allows callers who want an
> explicit site to pass in a non-NULL
> sitename to get returns only from
> that site.
>
> Hemanth has confirmed this fixes
> the problem for him. Please review
> and push. Patchset cleanly applies
> to master, 4.1.0, 4.0.next and 3.6.next.

Reviewed-by: Richard Sharpe <rsharpe at samba.org>

If someone else does not push this I will do so tonight, CA time.

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)