[PATCH 2/2] s4:dsdb/rootdse: Support netlogon request

[Nadezhda Ivanova]

Hi Benjamin and Andrew,
The patches look fine to me.

Reviewed-by: Nadezhda Ivanova <nivanova at symas.com>


On Tue, Oct 29, 2013 at 10:25 PM, Andrew Bartlett <abartlet at samba.org>wrote:

> On Tue, 2013-10-29 at 15:29 +0100, Benjamin Franzke wrote:
> > Hi Andrew,
> >
> > I have had that error sometimes while coding the torture test,
> > but now I dont get it reproduced..
> > Not with running smbtorture manually, and also not with make test
> > TESTS=samba4.netlogon-tcp.
> >
> > So I ran the test with make testenv in a while loop until it would fail.
> > After some iterations I got an error, but its another one
> > (NT_STATUS_NOT_FOUND) than you got.
> >
> > The server segfaulted because of a mistake in the rootdse/netlogon code
> > i've written.
> > The msg->dn was not part of msg's talloc tree, i've fixed this in:
> >
> https://git.bnfr.net/samba/commit/?h=netlogon-5&id=3d149a460892a7c78c635cc1303ed5eb0c1641ea
> >
> > With that patch the tests runs fine running it in many iterations.
> >
> > I dont know whether this might fix the issue you have,
> > but could you test whether it runs fine for you now?
>
> I'll test it today, but this looks very likely.
>
> I've squashed it into
>
> http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/bnfr-netlogon-5
>
> Nadya,
>
> Can you review these for us, as a second team reviewer?
>
> Andrew Bartlett
>
> --
> Andrew Bartlett
> http://samba.org/~abartlet/
> Authentication Developer, Samba Team           http://samba.org
> Samba Developer, Catalyst IT                   http://catalyst.net.nz
>
>
>