[PATCH] smbclient tarmode test suite

David Disseldorp ddiss at suse.de
Tue Oct 29 05:24:10 MDT 2013


Hi Andrew,

Thanks for the feedback...

On Tue, 29 Oct 2013 12:01:15 +1300
Andrew Bartlett <abartlet at samba.org> wrote:
...
> The test script seems to have hard-coded paths in it, that I don't see
> removed in later commits. 

Yes, the hard-coded paths remain at the end of the series, but are not
used under selftest, as all paths are explicitly specified as script
arguments.

Nevertheless, I've pushed a new commit which removes the unnecessary
defaults to the same aaptel_gsoc_clitar_tests branch:

https://git.samba.org/?p=ddiss/samba.git;a=commitdiff;h=71da85421168a7091d67b665f3a6d48d87a9b9cb

> I would also appreciate seeing the for-shadowed patchs showing how this
> is hooked into subunit and our selftest code.

Aurélien's selftest integration commit can be found at:
https://bitbucket.org/knarf/samba/commits/d2d4bfe93fc90794fe772603f0f14b5174142486

It is part of his full series at:
https://bitbucket.org/knarf/samba/commits/branch/gsoc_clitar_libarchive

Cheers, David


More information about the samba-technical mailing list