[PATCH 2/2] s4:dsdb/rootdse: Support netlogon request

[Andrew Bartlett]

On Mon, 2013-10-28 at 14:51 +0100, Benjamin Franzke wrote:
> Hi Andrew,
> 
> Thank you very much for your help! I've now passed the remote_address as
> opaque
> and tried to do a proper torture integration without duplicating the
> existing testcode.
> 
> Therefore I decided to pass the netlogon function as function pointer to
> the tests..
> And added a tcp replacement/alternative for cldap_netlogon.
> (It is located directly in the test c-file.)
> Adding tcp support to libcli looked wrong and like a lot of resulting
> ugliness to me.
> I hope you're ok with that?
> 
> Adding the patches as attachment.
> (used format-patch -C, which hopefully makes it a bit easier to review)
> 
> The Branch is also available at:
> https://git.bnfr.net/samba/log/?h=netlogon-4

This looks great!

I reviewed and pushed these to:
http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/bnfr-netlogon-4

I thought everything was good, but while just checking these over
however, I did an autobuild, and I got:

Trying netlogon level 0x1e
Trying with User=NULL
Trying with User=Administrator
ndr_pull_error(18): not all bytes consumed ofs[111] size[153]
Printing out netlogon server type flags: 127.0.0.21
The word is: 5117
NBT_SERVER_PDC NBT_SERVER_GC NBT_SERVER_LDAP NBT_SERVER_DS
NBT_SERVER_KDC NBT_SERVER_TIMESERV NBT_SERVER_CLOSEST
NBT_SERVER_WRITABLE NBT_SERVER_GOOD_TIMESERV
NBT_SERVER_FULL_SECRET_DOMAIN_6
UNEXPECTED(failure): samba4.ldap.netlogon-tcp.netlogon-tcp(dc)
REASON: _StringException:
_StringException: ../source4/torture/ldap/netlogon.c:122: status was
NT_STATUS_PORT_MESSAGE_TOO_LONG, expected NT_STATUS_OK: incorrect status

FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

Can you have a look into this a bit more?  It's annoying, because I
don't see it when I run the test on it's own :-(

[1/1 in 0s] samba4.ldap.netlogon-tcp(dc)
samba: EOF on stdin - terminating
samba child process 7098 exited with value 0

ALL OK (1 tests in 1 testsuites)

A summary with detailed information can be found in:
  ./st/summary

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Catalyst IT                   http://catalyst.net.nz