[PATCH] smbclient tarmode test suite

Andrew Bartlett abartlet at samba.org
Mon Oct 28 17:01:15 MDT 2013


On Mon, 2013-10-28 at 18:45 +0100, David Disseldorp wrote:
> As part of GSoC this year, Aurélien worked on improving smbclient's
> archival support. Prior to, and alongside his smbclient modifications,
> Aurélien wrote a comprehensive test suite covering the archival
> functionality offered by smbclient.
> 
> This patch set includes all commits covering the test script. It does
> not provide the selftest hooks, which will be proposed later along with
> the smbclient changes.
> 
> @Aurélien: three of these commits have been split from the corresponding
>            smbclient changes. I've kept your authorship details and
>            added a "[ddiss at samba.org: split...]" change-log comment.
> 
> Secondary reviews/pushes welcome.

The test script seems to have hard-coded paths in it, that I don't see
removed in later commits. 

I would also appreciate seeing the for-shadowed patchs showing how this
is hooked into subunit and our selftest code.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Catalyst IT                   http://catalyst.net.nz




More information about the samba-technical mailing list