[PATCH] wireshark pidl related

Matthieu Patou mat at samba.org
Sun Oct 27 12:31:43 MDT 2013


On 10/27/2013 12:35 AM, Stefan (metze) Metzmacher wrote:
> Hi Matthieu,
>
>> I'm in a cycle to fix pidl for wireshark so that we can use recent idl
>> for exisiting dissector (atsvc, dnsserver, ...) but also new idl like
>> frstrans or drsuapi.
>>
>> Here is a first set of patches for it:
>>
>> 0001-pidl-Define-the-attribute-Containspipe-as-valid-attr.patch
> This patch is not needed, we have a helper function called
> ContainsPipe(), please use that one.
>
>> 0002-librpc-add-idl-for-DFS-R-frsrtans-blobs.patch
>> 0003-librpc-Add-the-ContainsPipe-attribute-to-FRSTRANS-fu.patch
> As above.
>
>> 0004-pidl-wireshark-cosmetic-reformat.patch
>> 0005-pidl-wireshark-add-a-function-to-change-the-type-of-.patch
>> 0006-pidl-wireshark-generate-NDR64-enabled-code-for-enums.patch
>> 0007-pidl-wireshark-Display-Array-as-block-instead-of-byt.patch
>> 0008-pidl-wireshark-Do-not-add-the-signature-of-the-disse.patch
>> 0009-pidl-wireshark-add-the-type-dom_sid28-and-call-ad-ho.patch
>> 0010-pidl-wireshark-if-the-element-is-used-as-a-switch-st.patch
>> 0011-pidl-wireshark-SWITCH_TYPE-is-not-always-defined-use.patch
>> 0012-pidl-wireshark-clean-case-name-as-they-can-have-no-v.patch
>> 0013-pidl-wireshark-insure-that-we-have-an-entire-match-f.patch
>>
>> 0002-librpc-add-idl-for-DFS-R-frsrtans-blobs.patch
>>
>>
>>  From ac78b22ce8520cd9431e57ff2925317363e7260b Mon Sep 17 00:00:00 2001
>> From: Matthieu Patou <mat at matws.net>
>> Date: Tue, 1 Oct 2013 11:37:19 -0700
>> Subject: [PATCH 02/13] librpc: add idl for DFS-R (frsrtans) blobs
>>
>> Signed-off-by: Matthieu Patou <mat at matws.net>
>> ---
>>   librpc/idl/frstransblobs.idl | 29 +++++++++++++++++++++++++++++
>>   librpc/idl/wscript_build     |  2 +-
>>   librpc/wscript_build         |  5 +++++
>>   source4/librpc/wscript_build |  3 ++-
>>   4 files changed, 37 insertions(+), 2 deletions(-)
>>   create mode 100644 librpc/idl/frstransblobs.idl
>>
>> diff --git a/librpc/idl/frstransblobs.idl b/librpc/idl/frstransblobs.idl
>> new file mode 100644
>> index 0000000..b6ee30d
>> --- /dev/null
>> +++ b/librpc/idl/frstransblobs.idl
>> @@ -0,0 +1,29 @@
>> +#include "idl_types.h"
>> +
>> +//import "drsuapi.idl", "misc.idl", "samr.idl", "lsa.idl", "security.idl";
>> +
>> +[
>> +  uuid("12345778-1234-bcde-0001-000000000001"),
>> +  version(0.0),
>> +  pointer_default(unique),
>> +  //helper("../librpc/ndr/ndr_drsblobs.h"),
>> +  helpstring("DFS-R blobs")
>> +]
> Please remove the unused stuff here.
>
> The rest of the patches look ok from reading them,
> but I'd like to see the impact they have.
>
> For pidl changes it really got to maintain a branch
> where the generated files are commited and a reviewer is able to
> see the impact of each individual change, as there're often side effects
> which reveal bugs in inrelated code. Could you create such a branch
> maybe within the wireshark tree?

Updated list of patches for review.


-- 
Matthieu Patou
Samba Team
http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-librpc-add-idl-for-DFS-R-frsrtans-blobs.patch
Type: text/x-diff
Size: 3232 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131027/77a3c109/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-pidl-wireshark-cosmetic-reformat.patch
Type: text/x-diff
Size: 1539 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131027/77a3c109/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-pidl-wireshark-add-a-function-to-change-the-type-of-.patch
Type: text/x-diff
Size: 1420 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131027/77a3c109/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-pidl-wireshark-generate-NDR64-enabled-code-for-enums.patch
Type: text/x-diff
Size: 1559 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131027/77a3c109/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-pidl-wireshark-Display-Array-as-block-instead-of-byt.patch
Type: text/x-diff
Size: 4808 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131027/77a3c109/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-pidl-wireshark-Do-not-add-the-signature-of-the-disse.patch
Type: text/x-diff
Size: 1796 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131027/77a3c109/attachment-0005.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-pidl-wireshark-add-the-type-dom_sid28-and-call-ad-ho.patch
Type: text/x-diff
Size: 1464 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131027/77a3c109/attachment-0006.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-pidl-wireshark-if-the-element-is-used-as-a-switch-st.patch
Type: text/x-diff
Size: 1302 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131027/77a3c109/attachment-0007.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-pidl-wireshark-SWITCH_TYPE-is-not-always-defined-use.patch
Type: text/x-diff
Size: 2296 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131027/77a3c109/attachment-0008.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-pidl-wireshark-clean-case-name-as-they-can-have-no-v.patch
Type: text/x-diff
Size: 1134 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131027/77a3c109/attachment-0009.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-pidl-wireshark-insure-that-we-have-an-entire-match-f.patch
Type: text/x-diff
Size: 919 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131027/77a3c109/attachment-0010.patch>


More information about the samba-technical mailing list