[PATCH] wireshark pidl related

[Stefan (metze) Metzmacher]

Hi Matthieu,

> I'm in a cycle to fix pidl for wireshark so that we can use recent idl
> for exisiting dissector (atsvc, dnsserver, ...) but also new idl like
> frstrans or drsuapi.
> 
> Here is a first set of patches for it:
> 
> 0001-pidl-Define-the-attribute-Containspipe-as-valid-attr.patch

This patch is not needed, we have a helper function called
ContainsPipe(), please use that one.

> 0002-librpc-add-idl-for-DFS-R-frsrtans-blobs.patch
> 0003-librpc-Add-the-ContainsPipe-attribute-to-FRSTRANS-fu.patch

As above.

> 0004-pidl-wireshark-cosmetic-reformat.patch
> 0005-pidl-wireshark-add-a-function-to-change-the-type-of-.patch
> 0006-pidl-wireshark-generate-NDR64-enabled-code-for-enums.patch
> 0007-pidl-wireshark-Display-Array-as-block-instead-of-byt.patch
> 0008-pidl-wireshark-Do-not-add-the-signature-of-the-disse.patch
> 0009-pidl-wireshark-add-the-type-dom_sid28-and-call-ad-ho.patch
> 0010-pidl-wireshark-if-the-element-is-used-as-a-switch-st.patch
> 0011-pidl-wireshark-SWITCH_TYPE-is-not-always-defined-use.patch
> 0012-pidl-wireshark-clean-case-name-as-they-can-have-no-v.patch
> 0013-pidl-wireshark-insure-that-we-have-an-entire-match-f.patch
> 

> 0002-librpc-add-idl-for-DFS-R-frsrtans-blobs.patch
> 
> 
> From ac78b22ce8520cd9431e57ff2925317363e7260b Mon Sep 17 00:00:00 2001
> From: Matthieu Patou <mat at matws.net>
> Date: Tue, 1 Oct 2013 11:37:19 -0700
> Subject: [PATCH 02/13] librpc: add idl for DFS-R (frsrtans) blobs
> 
> Signed-off-by: Matthieu Patou <mat at matws.net>
> ---
>  librpc/idl/frstransblobs.idl | 29 +++++++++++++++++++++++++++++
>  librpc/idl/wscript_build     |  2 +-
>  librpc/wscript_build         |  5 +++++
>  source4/librpc/wscript_build |  3 ++-
>  4 files changed, 37 insertions(+), 2 deletions(-)
>  create mode 100644 librpc/idl/frstransblobs.idl
> 
> diff --git a/librpc/idl/frstransblobs.idl b/librpc/idl/frstransblobs.idl
> new file mode 100644
> index 0000000..b6ee30d
> --- /dev/null
> +++ b/librpc/idl/frstransblobs.idl
> @@ -0,0 +1,29 @@
> +#include "idl_types.h"
> +
> +//import "drsuapi.idl", "misc.idl", "samr.idl", "lsa.idl", "security.idl";
> +
> +[
> +  uuid("12345778-1234-bcde-0001-000000000001"),
> +  version(0.0),
> +  pointer_default(unique),
> +  //helper("../librpc/ndr/ndr_drsblobs.h"),
> +  helpstring("DFS-R blobs")
> +]

Please remove the unused stuff here.

The rest of the patches look ok from reading them,
but I'd like to see the impact they have.

For pidl changes it really got to maintain a branch
where the generated files are commited and a reviewer is able to
see the impact of each individual change, as there're often side effects
which reveal bugs in inrelated code. Could you create such a branch
maybe within the wireshark tree?

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131027/d4ae1170/attachment.pgp>