a few cleanup patches

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Oct 24 12:57:41 MDT 2013

On Thu, Oct 24, 2013 at 11:56:22AM -0700, Jeremy Allison wrote:
> No, I don't think we need to do that. I think this is the
> only issue that was missed, the rest of the code looks
> good - and as I say I really want to get rid of that
> horrible INTERNAL_OPEN_ONLY long term as it leads to
> mistakes :-(. As you know I'm a little busy with something
> else at the moment :-) else I'd be making it a higher priority.
> Just review and push if you agree !

We 100% need tests for this. This code is so freaking tricky
that we can't let anything controversial in without full
test coverage. Please push the reverts of the two
controversial patches.



SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list