[PATCH] Fix bug 10196 - RW Deny for a specific user is not overriding RW Allow for a group.
jra at samba.org
Wed Oct 23 10:39:52 MDT 2013
On Wed, Oct 23, 2013 at 01:50:03PM +0200, David Disseldorp wrote:
> Hi Jeremy,
> On Tue, 22 Oct 2013 10:52:55 -0700
> Jeremy Allison <jra at samba.org> wrote:
> > Here is a fix for a POSIX ACL mapping problem when winbindd
> > returns an ID_TYPE_BOTH id to smbd.
> > Confirmed as fixing the problem by the reporter.
> > It is just removing the "if (unixid.id == pst->st_ex_uid)"
> > condition that was previously tested before adding the
> > specific user id ACE and now always adds it if the type
> > is ID_TYPE_BOTH. Only applies to ACL set.
> > Please review !
> The code looks okay, but test_setntacl_policies_check_getposixacl fails
> with MismatchError: 15 != 10 at:
> 590 def test_setntacl_policies_check_getposixacl(self):
> 624 self.assertEquals(posix_acl.count, 10)
> I expect it should account for the new ID_TYPE_BOTH entries.
Thanks, I'll add an additional fix for that and re-post !
More information about the samba-technical