[PATCH] vfs_glusterfs: Enable per client log file

Christopher R. Hertel crh at samba.org
Mon Oct 21 19:20:01 MDT 2013

Richard pointed out that I probably misinterpreted Andrew's comment, and
that the "connect method" refers to the VFS Connect method.


If Richard's interpretation is correct, then we still have a situation in
which the userID being passed via the tree connect is the "primary" for
accessing the share.  It may not be the most useful piece of information for
forming log file names, but at least it'll be consistent for the share

...but the point of Poornima's patch is to allow a separate log file per
client, so that we don't have all of the logs generated from the Gluster VFS
module in one big file (as is now the case).  The latest iteration of the
patch *should* use functions from substitute.c to translate all variables,
not just %M, so that the user can decide how to form the log file name.

Chris -)-----

On 10/21/2013 11:35 AM, Christopher R. Hertel wrote:
> On 10/21/2013 05:09 AM, Andrew Bartlett wrote:
>> It may not matter for debug logging, but the connect method doesn't work
>> the way you think it does, which is confusing.  The issue is that it
>> only shows the name of the first user connecting, not any subsequent
>> users.
> That's true, but it's missing an explanation.
> The initial connection between client and server needs to be authenticated
> but authentication, by definition, creates a 'session'.  Once this initial
> session has been created, several more sessions may be created within the
> connection.  A "session" is created using the Session Setup command.  There
> are equivalent commands in both SMB1 and SMB2/3.
> Chris -)-----

"Implementing CIFS - the Common Internet FileSystem" ISBN: 013047116X
Samba Team -- http://www.samba.org/     -)-----   Christopher R. Hertel
jCIFS Team -- http://jcifs.samba.org/   -)-----   ubiqx development, uninq.
ubiqx Team -- http://www.ubiqx.org/     -)-----   crh at ubiqx.mn.org
OnLineBook -- http://ubiqx.org/cifs/    -)-----   crh at ubiqx.org

More information about the samba-technical mailing list