[Patch] use enums instead of int32

Matthieu Patou mat at matws.net
Mon Oct 21 00:29:27 MDT 2013


Hi Metze,

Update patches, I splitted in two (one for int32 to uint32) one for the 
enum.

On 10/20/2013 11:19 PM, Stefan (metze) Metzmacher wrote:
> Hi Matthieu,
>
>> -	typedef [switch_type(int32)] union {
>> -		[case(1)] drsuapi_DsGetDCInfoRequest1 req1;
>> +	typedef [switch_type(drsuapi_DsGetDCInfoCtrLevels)] union {
>> +		[case(DRSUAPI_DC_INFO_CTR_1)] drsuapi_DsGetDCInfoRequest1 req1;
>>   	} drsuapi_DsGetDCInfoRequest;
>>
> ...
>>   	WERROR drsuapi_DsGetDomainControllerInfo(
>>   		[in] policy_handle *bind_handle,
>> -		[in] int32 level,
>> +		[in] drsuapi_DsGetDCInfoCtrLevels level,
>>   		[in,ref,switch_is(level)] drsuapi_DsGetDCInfoRequest *req,
> Please keep the request level as int32 (or uint32 depending what
> Microsoft uses).
> The rest looks good.
>
> metze
Here
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-librpc-idl-replace-int32-by-the-enumeration-type-in-.patch
Type: text/x-diff
Size: 1961 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131020/4eb7fa78/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-librpc-idl-replace-int32-by-uint32-as-the-values-are.patch
Type: text/x-diff
Size: 1308 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131020/4eb7fa78/attachment-0001.patch>


More information about the samba-technical mailing list