[PATCH] s4-dsacl: Removed unnecessary privilege checks from sec_access_check_ds

[Andrew Bartlett]

On Wed, 2013-10-16 at 10:11 +0300, Nadezhda Ivanova wrote:
> Hi,
> Attached is a patch that fixes a problem found during I/O lab in Redmond -
> old code caused some explicit deny statements to be overlooked if the user
> has restore privileges.

I tried pushing it, but hit an autobuild failure in the ldap tests.  Can
you re-run those and sort it out?

[1521/1582 in 1h15m19s] samba4.ldap.python(dc)
baseDN: DC=samba,DC=example,DC=com

UNEXPECTED(failure):
samba4.ldap.python(dc).__main__.BasicTests.test_security_descriptor_add_neg(dc)
REASON: _StringException: _StringException: Content-Type:
text/x-traceback;charset=utf8,language=python
traceback
1C1
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line
128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line
368, in _run_test_method
    testMethod()
  File
"/memdisk/abartlet/a/b473928/samba/source4/dsdb/tests/python/ldap.py",
line 2661, in test_security_descriptor_add_neg
    self.assertTrue("nTSecurityDescriptor" in res[0])
AssertionError
0

FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

Thanks,

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Catalyst IT                   http://catalyst.net.nz