[PATCH] fix waf rpath ordering problem

[Andrew Bartlett]

On Wed, 2013-10-16 at 17:59 +0200, Michael Adam wrote:
> Hi,
> 
> attached find a patch that fixes WAF rpath ordering problem
> in our build:
> 
> When a library or system (like cups) provides an RPATH,
> e.g. with -Wl,-R or -Wl,-rpath, this was added by waf
> to the LINKFLAGS, wich was later prepended to our RPATH.
> But if the path by chance contains an older version of
> one of our internal libraries like talloc, this would lead
> to linking the too old talloc into our binaries.
> 
> This has been observed on, e.g., FreeBSD, with cups and
> talloc installed from packages/ports to /usr/local,
> but it is a general problem.
> 
> The patch has been tested and reviewed by Volker already
> and could hence be pushed to master (and I will unless I
> ge a veto.)
> 
> But I am copying Thomas (ita) since the patch touches wafadmin
> instead of wafsamba. So maybe you can also comment on whether
> there is a better way to fix this or whether this would also
> be a patch for upstream waf.

I'm so glad you figured this out!

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

(I'll let you push once we have a chance for ita to comment, but it
seems entirely reasonable to me)

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Catalyst IT                   http://catalyst.net.nz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131017/ca74cf0e/attachment.pgp>