[PATCH] winbind3: Fix CID 1107229 Uninitialized pointer read
Volker Lendecke
Volker.Lendecke at SerNet.DE
Wed Oct 16 13:38:17 MDT 2013
Just as a small distraction from oplocks... a Coverity fix.
Please review & push.
Thanks,
Volker
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 0d46f45cdb57bb27a26d79a352a2e42608294c08 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Wed, 16 Oct 2013 21:02:42 +0200
Subject: [PATCH] winbind3: Fix CID 1107229 Uninitialized pointer read
The first "goto done" would TALLOC_FREE the uninitialized "value"
Signed-off-by: Volker Lendecke <vl at samba.org>
---
source3/winbindd/winbindd_cm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
index 0f3e418..68b27e8 100644
--- a/source3/winbindd/winbindd_cm.c
+++ b/source3/winbindd/winbindd_cm.c
@@ -1565,7 +1565,8 @@ bool fetch_current_dc_from_gencache(TALLOC_CTX *mem_ctx,
const char *domain_name,
char **p_dc_name, char **p_dc_ip)
{
- char *key, *value, *p;
+ char *key, *p;
+ char *value = NULL;
bool ret = false;
char *dc_name = NULL;
char *dc_ip = NULL;
--
1.7.9.5
More information about the samba-technical
mailing list