[PATCH] Explain a bit of how loadparm works

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Oct 16 01:00:15 MDT 2013

On Wed, Oct 16, 2013 at 02:48:53PM +1300, Andrew Bartlett wrote:
> On Tue, 2013-10-15 at 08:48 +0200, Stefan (metze) Metzmacher wrote:
> > Hi Volker,
> > hi Andrew,
> > Maybe we can add some of this to lib/param/README?
> > 
> > I think the patches doesn't make the situation worse than it currently is,
> Thanks,
> Attached is a patch to add this documentation. 

Ok, good. See it as reviewed-by me. One thing sticks out
immediately though is the requirement to use talloc_unlink.
This needs to go ASAP. This is not acceptable. Sorry to be
so strict, but talloc_reference/talloc_unlink is just a
complete no-go in central code. Please focus on removing
that very, very soon.



SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list