[PATCH] remove undocumented "winbindd:socket dir" option

Andreas Schneider asn at samba.org
Mon Oct 14 02:52:27 MDT 2013

On Friday 11 October 2013 14:21:11 Andrew Bartlett wrote:
> The patch is posted for discussion, given the suggestion that parametric
> options, particularly undocumented ones, are not a good idea.
> This changes winbindd from using the undocumented winbindd:socket
> parameter, and changes it to use the documented "winbindd socket
> directory" parameter.
> Naturally, this creates issues if anybody is using the undocumented
> parameter, but it seems the better option long-term than removing it and
> instead moving the s4 winbind to documenting "winbindd:socket dir".
> This was originally added to support make test in 2007:
> 0805a4bc715f055fd68c5e27bd46eadfb101e1b9
> If we are in agreement, please review/push.
> There are similar parameters that need to be looked at.  For example,
> "winbindd privileged socket directory" is also not used in the s3
> winbindd code, but using it might break sites that rely on it being
> strictly under 'state directory'.  In this case perhaps we should remove
> the parameter?

Reviewed-by: Andreas Schneider <asn at samba.org>

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list