[PATCH] provision fixes for subdomain support

Andrew Bartlett abartlet at samba.org
Thu Oct 10 19:35:56 MDT 2013


On Wed, 2013-10-09 at 10:25 +0200, Stefan (metze) Metzmacher wrote:
> Am 08.10.2013 05:19, schrieb Andrew Bartlett:
> > On Sat, 2013-10-05 at 09:13 +1300, Andrew Bartlett wrote:
> >> On Fri, 2013-09-27 at 20:32 -0700, Andrew Bartlett wrote:
> >>> On Fri, 2013-09-27 at 14:30 -0700, Andrew Bartlett wrote:
> >>>> These are some more fixes to restore subdomain support that we had a few
> >>>> years back but which has bitrotted. 
> >>>>
> >>>> This also includes a fix for our partitions module to give clearer
> >>>> errors, for a case I kept seeing during testing on metadata.tdb.
> >>>>
> >>>> Andrew Bartlett
> >>>
> >>> The attached fixes include the full patch set, and are tested on their
> >>> own.  (I found part of one of these patches in another patch I didn't
> >>> send). 
> >>>
> >>> Please Review/merge.
> >>
> >> Metze,
> >>
> >> I seem to recall you had some comment on one of these patches.  Can we
> >> merge the rest, and can you remind me what your issues where?  I think
> >> you wanted something re-ordered. 
> >>
> >> Thanks,
> > 
> > I've not yet re-ordered the code, and not changed the Legacy DNS stuff,
> > but otherwise I've fixed up the hunk-in-wrong-patch issue you raised.  I
> > don't currently have a modal windows parent/child set up (need to fire
> > up some more VMs tomorrow), so I'll check what objects are where in
> > those.  I think we should incorporate anything we learn there into a
> > separate later patch. 
> > 
> > The fixed patches are in my subdomain-for-master branch. 
> 
> Please have a look at my branch
> https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-abartlet2
> 
> Please review my additional patches and push everything.

I've fixed up and updated the patches, and done a successful scratch
autobuild.  The branch is at
http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/subdomain-for-master

You will probably want to look at the changes to the acl module in
particular, or skip that patch. 

Please review/push.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Catalyst IT                   http://catalyst.net.nz




More information about the samba-technical mailing list