[PATCH] remove undocumented "winbindd:socket dir" option

Andrew Bartlett abartlet at samba.org
Thu Oct 10 19:21:11 MDT 2013

The patch is posted for discussion, given the suggestion that parametric
options, particularly undocumented ones, are not a good idea.

This changes winbindd from using the undocumented winbindd:socket
parameter, and changes it to use the documented "winbindd socket
directory" parameter.  

Naturally, this creates issues if anybody is using the undocumented
parameter, but it seems the better option long-term than removing it and
instead moving the s4 winbind to documenting "winbindd:socket dir".

This was originally added to support make test in 2007:

If we are in agreement, please review/push.

There are similar parameters that need to be looked at.  For example,
"winbindd privileged socket directory" is also not used in the s3
winbindd code, but using it might break sites that rely on it being
strictly under 'state directory'.  In this case perhaps we should remove
the parameter?


Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Catalyst IT                   http://catalyst.net.nz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-winbindd-Remove-undocumented-winbindd-socket-dir-.patch
Type: text/x-patch
Size: 4247 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131011/10e15b92/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-docs-Explain-why-this-option-should-not-be-used.patch
Type: text/x-patch
Size: 1151 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131011/10e15b92/attachment-0001.bin>

More information about the samba-technical mailing list