Suggested patch - change of namespace from security to trusted for acl_xattr module

Hafeez Bana hafeez.bana at gmail.com
Thu Oct 10 06:52:33 MDT 2013


Hi All,

In order to make a fused mounted glusterfs volume with with samba modules
acl_xattr. The following patch needs to be applied.

I don't think this will make it into the main tree considering how it will
break backwards compatibility - but I thought I would put it out there.

Ultimately having the xattr namespace configurable but defaulting to
security would be the way to go..

Thx.
Hb


----------------
# cat debian/patches/xattr_change_namespace.diff                        |
Index:
samba-3.6.3/source3/librpc/gen_ndr/py_xattr.c
|
===================================================================
|
--- samba-3.6.3.orig/source3/librpc/gen_ndr/py_xattr.c  2012-01-29
19:42:20.000000000 +0000              |
+++ samba-3.6.3/source3/librpc/gen_ndr/py_xattr.c       2013-10-10
13:46:04.554496000 +0100              |
@@ -2198,7 +2198,7
@@
|
        PyModule_AddObject(m, "XATTR_SD_HASH_TYPE_NONE",
PyInt_FromLong(0x0));                           |
        PyModule_AddObject(m, "XATTR_MAX_STREAM_SIZE_TDB",
PyInt_FromLong(0x100000));                    |
        PyModule_AddObject(m, "XATTR_DOSEAS_NAME",
PyString_FromString("user.DosEAs"));                  |
-       PyModule_AddObject(m, "XATTR_NTACL_NAME",
PyString_FromString("security.NTACL"));                |
+       PyModule_AddObject(m, "XATTR_NTACL_NAME",
PyString_FromString("trusted.NTACL"));                 |
        PyModule_AddObject(m, "XATTR_DOSSTREAMS_NAME",
PyString_FromString("user.DosStreams"));          |
        PyModule_AddObject(m, "XATTR_DOSINFO_ALLOC_SIZE",
PyInt_FromLong(XATTR_DOSINFO_ALLOC_SIZE));     |
        PyModule_AddObject(m, "XATTR_DOSINFO_CHANGE_TIME",
PyInt_FromLong(XATTR_DOSINFO_CHANGE_TIME));   |
Index:
samba-3.6.3/source3/librpc/gen_ndr/xattr.h
|
===================================================================
|
--- samba-3.6.3.orig/source3/librpc/gen_ndr/xattr.h     2012-01-29
19:42:20.000000000 +0000              |
+++ samba-3.6.3/source3/librpc/gen_ndr/xattr.h  2013-10-10
13:45:42.394642000 +0100                      |
@@ -19,7 +19,7
@@
|
 #define XATTR_DOSSTREAM_PREFIX ( "user.DosStream."
)                                                    |
 #define XATTR_MAX_STREAM_SIZE  ( 0x4000
)                                                               |
 #define XATTR_MAX_STREAM_SIZE_TDB      ( 0x100000
)                                                     |
-#define XATTR_NTACL_NAME       ( "security.NTACL"
)                                                     |
+#define XATTR_NTACL_NAME       ( "trusted.NTACL"
)                                                      |
 #define XATTR_SD_HASH_SIZE     ( 64
)                                                                   |
 #define XATTR_SD_HASH_TYPE_NONE        ( 0x0
)                                                          |
 #define XATTR_SD_HASH_TYPE_SHA256      ( 0x1 )


More information about the samba-technical mailing list