Patch submission version 4

[Stéphane PURNELLE]

Hi,

In attached file, patch in GIT format with some typo correction

could you review and push in your master (samba4.1) if ok.




thx

         Stéphane Purnelle


-----------------------------------
Stéphane PURNELLE                         Admin. Systèmes et Réseaux 
Service Informatique       Corman S.A.           Tel : 00 32 (0)87/342467

Andrew Bartlett <abartlet at samba.org> wrote on 09/10/2013 04:44:25:

> De : Andrew Bartlett <abartlet at samba.org>
> A : Stéphane PURNELLE <stephane.purnelle at corman.be>, 
> Cc : samba-technical at samba.org
> Date : 09/10/2013 04:51
> Objet : Re: Patch submission version 4
> 
> On Wed, 2013-10-02 at 13:32 +0200, Stéphane PURNELLE wrote:
> > Independent of usage of posixAccount objectclass and RFC2307, 
uidNumber, 
> > gidNumber, ...
> > 
> > This patchset permit to set uidNumber and gidNumber using samba-tool 
and 
> > verify if uidNumber or gidNumber is already exist or not.
> 
> Thank you for looking into this.
> 
> One issue is that we cannot know if a uid or gid is in use, if the
> directory is not in a good replication state right now.   So, while a
> very valuable too, it isn't able to be a perfect failsafe. 
> 
> On the patch itself, you have a number of style and indenting issues.
> In particular, make sure you always have a space after a , and that you
> lay the functions out in the same way as other examples in the code.
> 
> It would also really help if you could also commit the changes into a
> git repository (with git commit -s), and run git-format-patch -1 to
> produce the patch.  That way, we have your signed off patch with commit
> message all sorted, ready to get into master. 
> 
> Thanks,
> 
> Andrew Bartlett
> -- 
> Andrew Bartlett
> http://samba.org/~abartlet/
> Authentication Developer, Samba Team           http://samba.org
> Samba Developer, Catalyst IT                   http://catalyst.net.nz
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Patchset-for-manager-uidNumber-and-gidNumer.patch
Type: application/octet-stream
Size: 9119 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131009/f22cc902/attachment.obj>