[PATCH] provision fixes for subdomain support

Stefan (metze) Metzmacher metze at samba.org
Wed Oct 9 02:25:03 MDT 2013


Am 08.10.2013 05:19, schrieb Andrew Bartlett:
> On Sat, 2013-10-05 at 09:13 +1300, Andrew Bartlett wrote:
>> On Fri, 2013-09-27 at 20:32 -0700, Andrew Bartlett wrote:
>>> On Fri, 2013-09-27 at 14:30 -0700, Andrew Bartlett wrote:
>>>> These are some more fixes to restore subdomain support that we had a few
>>>> years back but which has bitrotted. 
>>>>
>>>> This also includes a fix for our partitions module to give clearer
>>>> errors, for a case I kept seeing during testing on metadata.tdb.
>>>>
>>>> Andrew Bartlett
>>>
>>> The attached fixes include the full patch set, and are tested on their
>>> own.  (I found part of one of these patches in another patch I didn't
>>> send). 
>>>
>>> Please Review/merge.
>>
>> Metze,
>>
>> I seem to recall you had some comment on one of these patches.  Can we
>> merge the rest, and can you remind me what your issues where?  I think
>> you wanted something re-ordered. 
>>
>> Thanks,
> 
> I've not yet re-ordered the code, and not changed the Legacy DNS stuff,
> but otherwise I've fixed up the hunk-in-wrong-patch issue you raised.  I
> don't currently have a modal windows parent/child set up (need to fire
> up some more VMs tomorrow), so I'll check what objects are where in
> those.  I think we should incorporate anything we learn there into a
> separate later patch. 
> 
> The fixed patches are in my subdomain-for-master branch. 

Please have a look at my branch
https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-abartlet2

Please review my additional patches and push everything.

metze


More information about the samba-technical mailing list