[PATCH] [CIFS] Allow setting per-file compression via SMB3

Steve French smfrench at gmail.com
Tue Oct 8 08:51:05 MDT 2013


On Tue, Oct 8, 2013 at 2:16 AM, Stefan (metze) Metzmacher
<metze at samba.org> wrote:
> Hi Steve,
>
>> Allow cifs/smb2/smb3 to return whether or not a file is compressed
>> via lsattr, and allow SMB3 to set the per-file compression flag
>> ("chattr +c filename" on an smb3 mount).
>
> Why is this SMB3 specific?

Just to make testing easier.  I can add SMB2.1 easily enough
and test it against Windows 7 this morning, and SMB2.02 should be


>> Windows users often set the compressed flag (it can be
>> done from the desktop and file manager).  David Disseldorp
>> has patches to Samba server to support this (at least on btrfs)
>> which are complementary to this.
>>
>> Wish chattr supported the per-file encryption flag (that
>> presumably would be easy to set too via SMB3)
>
> It seems there're some unrelated changes in the commit,
> wouldn't it be better to split this into 2 or 3 commits?

There was one header cleanup for the sockaddr info in the network interface
request that I will remove from this and move to the query network
interfaces fsctl patch


-- 
Thanks,

Steve


More information about the samba-technical mailing list