[PATCH] [WIP] Improve ldb and show_deleted

Andrew Bartlett abartlet at samba.org
Mon Oct 7 15:57:07 MDT 2013


Attached are two patches for interest:
 - the first three attempt to finally fix our show_deleted module to
check the base DN for being deleted, not just return 0 entries. 
 - patch 4 is an idea that came to mind, which hasn't been fully tested.
In this patch I convert a subtree search into an base search, if the DN
is a leaf node (as shown by the one-level index). 

All are inspired by trying to improve LDB performance by short-cutting
potential cases for unindexed subtree searches.

Currently they cause an upgradeprovision test to die fail, which I need
to dig into further, but I figured they might be interesting
regardless. 

Andrew Bartlett
-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Catalyst IT                   http://catalyst.net.nz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba_upgradeprovision-Improve-error-messages-and-on.patch
Type: text/x-patch
Size: 2431 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131008/feb7c557/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-dsdb-Add-show_deleted_dummy-module-for-use-in-samba3.patch
Type: text/x-patch
Size: 3611 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131008/feb7c557/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-dsdb-show_deleted-Check-if-the-base-DN-is-deleted-be.patch
Type: text/x-patch
Size: 8790 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131008/feb7c557/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-lib-ldb-Do-a-one-level-search-before-doing-a-subtree.patch
Type: text/x-patch
Size: 1767 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131008/feb7c557/attachment-0003.bin>


More information about the samba-technical mailing list