[PATCHSET] fix and improve shadow_copy2 [Re: vfs_shadow_copy2] configuration

Michael Adam obnox at samba.org
Fri Oct 4 13:21:01 MDT 2013

For people who did not follow the previous discussions:

This patchset essentially fixes shadow_copy2 for the
"classical" case, i.e. with "shadow:snapdirseverywhere = false".

The snapdirseverywhere mode was introduced with 4.0. This is
a mode where snapshot directories can be found in many places
in the directory tree and not just in one. It was noted only
with some delay that this introduced regressions with the
"classical" modes of shadow_copy2.

This patchset fixes those regressions.
So I consider this patchset fairly important, and we should
also file bug reports for 4.0 and 4.1 and bring this patchset
to these releases.

But first to master... :-)

Cheers - Michael

On 2013-10-04 at 14:19 +0200, Michael Adam wrote:
> Hi,
> attached find the polished patchset that
> contains all my fixes and improvements for the
> shadow_copy2 module.
> The code is the same as the one tested before
> from the WIP patchset, except for very few minor
> cleanups and a couple of omitted debug messages.
> Review/comments/push appreciated!
> Note: the patchset on top of current master is in my
> "master-shadow_copy2 " branch in
> git://git.samba.org/obnox/samba/samba-obnox.git
> http://gitweb.samba.org/?p=obnox/samba/samba-obnox.git;a=shortlog;h=refs/heads/master-shadow_copy2
> A few WIP patches, in particular a started torture
> suite for the shadow-copies are in the master-shadow_copy2-wip branch
> http://gitweb.samba.org/?p=obnox/samba/samba-obnox.git;a=shortlog;h=refs/heads/master-shadow_copy2-wip
> Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131004/f1f2d98b/attachment.pgp>

More information about the samba-technical mailing list