Can't seem to get any commit past autobuild at the moment.
jra at samba.org
Wed Oct 2 09:53:11 MDT 2013
On Tue, Oct 01, 2013 at 05:28:51PM +0200, David Disseldorp wrote:
> Hi Jeremy,
> On Mon, 30 Sep 2013 19:49:41 -0700
> Jeremy Allison <jra at samba.org> wrote:
> > Seems to be failing in environment setup.
> > Can someone with more autobuild experience
> > than me take a look ? I'm out sick at home
> > with a wrecked lower back at the moment, so I'm
> > not exactly on top of my game :-(.
> Hope you have a quick recovery.
> Looking at autobuild, I see the following python call segfault:
> PYTHONPATH=bin/python:lib/subunit/python:lib/testtools python -m subunit.run $LISTOPT samba.tests.samba3
> The backtrace points the finger at the loadparm code-path:
> #0 0x00007fffe76de1ef in add_a_service (pservice=0x7fffe7915240, name=0xe3ebb0 "cd1") at ../source3/param/loadparm.c:1586
> #1 0x00007fffe76e32fe in do_section (pszSectionName=0xe3ebb0 "cd1", userdata=0x0) at ../source3/param/loadparm.c:3558
> With the "Remove dead code" change, it looks like i is no longer
> initialised leading up to:
> 1586 ServicePtrs[i]->valid = true;
> I'll propose a rework of your patch which initialises i to iNumServices.
> Hmph, I should have caught this in the initial review.
Thanks David. I should have caught this in the inital
writing of the code too :-).
More information about the samba-technical