samba_backup bug fix, error message enhancements, command line enhancement

Brian Martin samba-ml1 at
Tue Oct 1 15:53:35 MDT 2013

On 09/30/2013 05:14 PM, Matthieu Patou wrote:
> On 09/25/2013 05:24 PM, Brian Martin wrote:
>> I'm a first-time patch submitter, so please guide me if I haven't
>> prepared this properly.
>> The attached patch updates source4/scripting/bin/backup_samba as
>> follows:
>>     - Fix retention period bug when deleting old backups ($DAYS variable
>>       could be set, but was ignored).
>>     - Allow retention period ("DAYS") to be specified as a command
>> line parameter.
>>     - Allow individual positional parameters to be left at the default
>>       by specifying "-".
>>     - Use IS0 8601 standard dates (yyyy-mm-dd instead of mmddyyyy).
>>     - Display tar exit codes when reporting errors.
>>     - Don't send error messages to /dev/null, so we know what failed.
>>     - Suppress useless tar "socket ignored" message.
>> Thank you for considering this patch.
>>                                    -Brian Martin
> Looks good to me too.
> Most probably we can merge your 2 patches together ?
> Matthieu.

Yes, merging the two patches together is fine.  I asked Andrew about 
that earlier, and he said I could go ahead and prepare the second patch 
on top of the first.

Thanks for reviewing these patches, Matthieu.  Please let me know if you 
need anything further from me.

                                           -Brian Martin

More information about the samba-technical mailing list