Add missing parameters to drs_Replicate in rodc.py

[Garming Sam]

On 22/11/13 05:05, Michael Brown wrote:
> This patch makes the drs_Replicate actually work... there was a 
> missing parameter. And adds the transaction cancellation on error.
>
> sles-shire:/home/michael # samba-tool rodc preload 'michael' --server 
> main.adlab.netdirect.ca
> Replicating DN CN=Michael 
> Brown,OU=Main,OU=Offices,DC=main,DC=adlab,DC=netdirect,DC=ca
> ERROR(<type 'exceptions.TypeError'>): uncaught exception - __init__() 
> takes exactly 6 arguments (5 given)
>   File "/usr/lib64/python2.6/site-packages/samba/netcmd/__init__.py", 
> line 175, in _run
>     return self.run(*args, **kwargs)
>   File "/usr/lib64/python2.6/site-packages/samba/netcmd/rodc.py", line 
> 94, in run
>     repl = drs_Replicate("ncacn_ip_tcp:%s[seal,print]" % server, lp, 
> creds, local_samdb)
> A transaction is still active in ldb context [0xd614f0] on 
> tdb:///var/lib/samba/private/sam.ldb
>
> M.
>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
I've tested this change and it seems to work.

Is there any chance you can write a test so the automated system can 
catch it in the future?



Garming Sam