[PATCHSET] enable ctdb's selftest in autobuild
obnox at samba.org
Wed Nov 27 10:56:04 MST 2013
On 2013-11-27 at 10:22 +0100, Michael Adam wrote:
> On 2013-11-27 at 17:25 +1100, Martin Schwenke wrote:
> > That said, can we please defer the following fix (and, therefore, the
> > whole patchset) for a few days?
> > ctdb:tests: use TEST_VAR_DIR instead of /tmp in 76_ctdb_pdb_recovery.sh
> > For the statd-callout rewrite we added a "ctdb ptrans" command that
> > reads data from stdin. This solves the remote temporary file problem
> > by completely avoiding it. Amitay is going to push those patches
> > very soon and then we could fix this properly by using "ctdb ptrans".
> Sure. Sounds good.
Did it , see my master-ctdb branch, but it fails
autobuild for me currently (pfetch fails with
empty record). will look later...
> > * Again, it was my suggestion to 2>/dev/null the output of the cat
> > commands in the ip stub. However, in retrospect, we can just get rid
> > of them and replace them with "echo". Then we shouldn't have a
> > broken pipe issue. I've done this but haven't had time to push this
> > anywhere. Wanted to get a reply to you as quickly as possible...
> Ok, I was wondering about the practice of cat-ing one-line
> here-docucments anyways... :)
Done (in my master-ctdb branch, waiting for review).
But after doing it I am not certain I like the echo
more than the cat, especially since there is a multiline
here doc cat in ip_link_show(), which I did not touch
yet since it does not break make test in autobuild.
> > Apart from that we could push most of the patchset, except the bit that
> > actually makes it get run in autotest. Let's ping-pong some
> > more... :-)
> Right, will hack on the patches some more and ping back
Pushed those patches that are already reviewed sufficiently.
The others, mostly from me, awaiting review are in my
master-ctdb branch on top.
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 215 bytes
Desc: Digital signature
More information about the samba-technical