[PATCHSET] enable ctdb's selftest in autobuild
obnox at samba.org
Wed Nov 27 02:22:20 MST 2013
Comments on the list after a long irc discussions:
On 2013-11-27 at 17:25 +1100, Martin Schwenke wrote:
> Hi Michael,
> On Mon, 25 Nov 2013 17:21:37 +0100, Michael Adam <obnox at samba.org>
> > attached is a patchset, I have been pair- and
> > ping-pong-programming with Martin and Amitay during
> > the last week or so.
> > It enables ctdb selftest in samba's autobuild.
> A couple of things:
> * Sorry, my suggestion to use $TEST_VAR_DIR was bogus. It works with
> local daemons (so helps in autobuild) but doesn't work when you run
> the tests on a cluster because $TEST_VAR_DIR doesn't exist on the
> cluster nodes.
> This patch:
> ctdb:tests: use TEST_VAR_DIR instead of /tmp in integration.bash
> can be dropped for now because the functionality is only used in
> "complex" tests, which need a cluster to run on. So, we don't need
> this for autobuild.
Ok, we can do this for now, but it is not very robust. :-)
As discussed, I would like to split up integration.bash
so that is becomes more obvious which parts are used where.
> The real fix is probably to create and ship 99.test (like 99.timeout
> - probably replacing it). I have a good idea of how to make it
> work... and get rid of a lot of bogus code in integration.bash. I
> wrote that code but now I see a much better way. :-)
> That said, can we please defer the following fix (and, therefore, the
> whole patchset) for a few days?
> ctdb:tests: use TEST_VAR_DIR instead of /tmp in 76_ctdb_pdb_recovery.sh
> For the statd-callout rewrite we added a "ctdb ptrans" command that
> reads data from stdin. This solves the remote temporary file problem
> by completely avoiding it. Amitay is going to push those patches
> very soon and then we could fix this properly by using "ctdb ptrans".
Sure. Sounds good.
> * Again, it was my suggestion to 2>/dev/null the output of the cat
> commands in the ip stub. However, in retrospect, we can just get rid
> of them and replace them with "echo". Then we shouldn't have a
> broken pipe issue. I've done this but haven't had time to push this
> anywhere. Wanted to get a reply to you as quickly as possible...
Ok, I was wondering about the practice of cat-ing one-line
here-docucments anyways... :)
> Apart from that we could push most of the patchset, except the bit that
> actually makes it get run in autotest. Let's ping-pong some
> more... :-)
Right, will hack on the patches some more and ping back
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 215 bytes
Desc: Digital signature
More information about the samba-technical