ddiss at suse.de
Fri Nov 22 07:39:54 MST 2013
On Fri, 22 Nov 2013 14:51:05 +0100
"Stefan (metze) Metzmacher" <metze at samba.org> wrote:
> > Is there any advantage, aside from smb1 uniformity?
> Yes, one less malloc() per request, which costs a lot.
Ok, but having the request processing code-path explicitly use the
talloc hierarchy attached to the request instead of the stackframe would
provide the same benefit (albeit with a huge change).
> I'll add a comment to the commit message...
> The aim is to do at most one malloc() per request.
> I have plans to reclaim unused talloc_stackframe_pool() memory,
> instead of doing one malloc() event loop, but that might come later.
Can't say I like where this is heading. I'd prefer to keep this kind of
garbage collection complexity and overhead out of talloc, but I'll leave
it for others to decide.
More information about the samba-technical