[SCM] Samba Shared Repository - branch master updated

Jelmer Vernooij jelmer at samba.org
Thu Nov 21 16:18:37 MST 2013


On Thu, Nov 21, 2013 at 10:13:03PM +0100, Christian Ambach wrote:
> - Log -----------------------------------------------------------------
> commit 4ea92841b72a7b701a7c0fadf63430a7d0a3fac8
> Author: Christian Ambach <ambi at samba.org>
> Date:   Mon Nov 18 20:02:41 2013 +0100
> 
>     lib/util: use proper include for struct stat
>     
>     use <sys/stat.h> instead of forward declaring it
>     This fixes the build on AIX
>     
>     Bug: https://bugzilla.samba.org/show_bug.cgi?id=10276
>     
>     Signed-off-by: Christian Ambach <ambi at samba.org>
>     Reviewed-by: Andreas Schneider <asn at samba.org>
>     
>     Autobuild-User(master): Christian Ambach <ambi at samba.org>
>     Autobuild-Date(master): Thu Nov 21 22:12:45 CET 2013 on sn-devel-104
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  lib/util/samba_util.h |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> 
> Changeset truncated at 500 lines:
> 
> diff --git a/lib/util/samba_util.h b/lib/util/samba_util.h
> index 243ed3e..f52347e 100644
> --- a/lib/util/samba_util.h
> +++ b/lib/util/samba_util.h
> @@ -27,6 +27,9 @@
>  /* for TALLOC_CTX */
>  #include <talloc.h>
>  
> +/* for struct stat */
> +#include <sys/stat.h>
> +
>  /**
>   * @file
>   * @brief Helpful macros
> @@ -627,7 +630,6 @@ _PUBLIC_ bool directory_exist(const char *dname);
>  /**
>   Check file permissions.
>  **/
> -struct stat;
>  _PUBLIC_ bool file_check_permissions(const char *fname,
>  				     uid_t uid,
>  				     mode_t file_perms,

We generally try to keep platform-specific includes like this in
lib/replace/system. Would it perhaps make sense to include
system/filesys.h instead?

Jelmer


More information about the samba-technical mailing list