posix remove acl support

Steve French smfrench at gmail.com
Wed Nov 20 22:35:00 MST 2013


On Wed, Nov 20, 2013 at 11:16 PM, Jeremy Allison <jra at samba.org> wrote:
> On Wed, Nov 20, 2013 at 11:04:57PM -0600, Steve French wrote:
>> Jeremy,
>> As you noted we need to add support to cifs kernel client to remove POSIX ACLs.
>>
>> This patch is close (it seems to work, but wireshark did not like the
>> buffer lengths when I did a setfacl -k although setacl -b looked fine.
>>
>> It works basically by passing the minimum size in for the ACL (0
>> entries) - sending a zero in the number of ACEs removes the entry.
>>
>> Comments/feedback?
>
> Yep, sending a zero size for the number of ACE entries
> will delete the ACL on the Samba server side.
>
> I don't have the capability to test your patch right now
> though, but you should be able to test it against any
> modern Samba server installation.

Looks fine so far (with the exception of the on the wire formatting
problem in one case above - which samba seems ok with or wireshark has
a bug - need to check tomorrow)


-- 
Thanks,

Steve


More information about the samba-technical mailing list