The Wrapper Project
abartlet at samba.org
Wed Nov 20 12:38:59 MST 2013
On Wed, 2013-11-20 at 19:59 +0100, Jelmer Vernooij wrote:
> Andreas is proposing moving a chunk of code out of the Samba codebase
> taking over maintenance of it, removing it from Samba and having Samba
> depend on that code. 
> This means that code to which everybody in the Samba team could easily
> contribute to previously is now harder to edit, harder to follow, and changes
> to it are no longer necessarily audited.
My reservations are based around how we develop, but also how we build
and ship the code as well, because to me it is critical that we continue
to build and ship these testing wrappers in-tree.
These wrappers were originally developed specifically to make 'make
test' trivial enough to run that not only all developers could use it,
but that all our build farm hosts could as well. I'm concerned about
any changes that make that harder for Samba.
I think it's great that other projects can use this technology, but we
need to ensure that changes made to Samba are the best for Samba,
because this code is *absolutely critical* to our CI infrastructure.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical