[PATCH 0/6] various minor printing code cleanups

Guenther Deschner gd at samba.org
Wed Nov 20 00:19:05 MST 2013


Moin David,

changes look good. Pushed to autobuild.

Thanks,
Guenther

On 20/11/13 00:48, David Disseldorp wrote:
> Encountered while working on bug 10271.
> Please review / push.
>
> Cheers, David
>
>
> The following changes since commit 2d91577f984bc83c2c87141cfdda87d068060b32:
>
>    smbd: Fix a talloc hierarchy problem in msg_channel (2013-11-20 00:13:50 +0100)
>
> are available in the git repository at:
>
>    git://git.samba.org/ddiss/samba.git printing_cleanups
>
> for you to fetch changes up to 7d913f387e1b97b6d78df4389e748bec33f3e956:
>
>    debug: remove unused sys_adminlog (2013-11-20 00:45:43 +0100)
>
> ----------------------------------------------------------------
> David Disseldorp (6):
>        printing: return WERROR from print_access_check
>        messaging: use local talloc ctx instead of talloc_tos
>        loadparm: use lp_printername ctx param instead of tos
>        printing: fix double space in debug statement
>        printing: use DEBUG instead of sys_adminlog
>        debug: remove unused sys_adminlog
>
>   source3/include/includes.h                  |  3 ---
>   source3/include/nt_printing.h               |  6 +++---
>   source3/lib/messages_local.c                |  8 ++++----
>   source3/lib/system.c                        | 25 -------------------------
>   source3/param/loadparm.c                    |  2 +-
>   source3/printing/nt_printing.c              | 31 ++++++++++++-------------------
>   source3/printing/printing.c                 | 74 ++++++++++++++++++++++++++++++--------------------------------------------
>   source3/rpc_server/spoolss/srv_spoolss_nt.c | 16 ++++++++--------
>   8 files changed, 58 insertions(+), 107 deletions(-)
>


-- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org


More information about the samba-technical mailing list