[PATCH] lib/param: Consolidate code to enable smb signing on the server, always enable on AD DC

[Andrew Bartlett]

On Mon, 2013-11-18 at 11:04 +0100, David Disseldorp wrote:
> Hi Andrew,
> 
> On Sat, 16 Nov 2013 17:46:21 +0100
> David Disseldorp <ddiss at suse.de> wrote:
> 
> > On Sat, 16 Nov 2013 09:18:30 +1300
> > Andrew Bartlett <abartlet at samba.org> wrote:
> > 
> > > Fixed.  Attached.
> > > 
> > > Please review/push.  
> > 
> > LGTM. Pushed to autobuild.
> 
> This patch-set doesn't appear to make it through autobuild:
> ...
> [1435/1584 in 1h14m3s] samba4.blackbox.smbclient(s3member:local)
> Connection to \\LOCALADMEMBER\tmp failed - NT_STATUS_LOGON_FAILURE
> UNEXPECTED(failure): samba4.blackbox.smbclient(s3member:local).Test login with --machine-pass without kerberos(s3member:local)
> REASON: _StringException: _StringException: No reason specified
> 
> FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
> 
> A summary with detailed information can be found in:
>   ./bin/ab/summary
> ERROR: test failed with exit code 1
> 
> I've not taken a closer look yet.

While on a train (yes, they have those over here, just not shiny fast
ones, they call them 'scenic' for a reason :-) on Sunday I looked over
your autobuild output, and couldn't reproduce that with an isolated
test.  

I suspect somehow it is racing with a password change of the domain
member account, but I can't be certain.  I think the next step needs to
be a private autobuild on sn-devel.  I'll try for that in the next day
or so.

Andrew Bartlett