[PATCH] lib/param: Consolidate code to enable smb signing on the server, always enable on AD DC

Andrew Bartlett abartlet at samba.org
Fri Nov 15 13:18:30 MST 2013


On Fri, 2013-11-15 at 08:20 +0100, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> 
> > +bool lpcfg_server_signing_allowed(struct loadparm_context *lp_ctx, bool *mandatory)
> > +{
> > +	bool allowed = true;
> > +	*mandatory = false;
> > +
> > +	enum smb_signing_setting signing_setting = lpcfg_server_signing(lp_ctx);
> > +	if (signing_setting == SMB_SIGNING_DEFAULT) {
> > +		/*
> 
> Please move '*mandatory = false;' after the 'enum smb_signing_setting
> signing_setting'
> line.

Fixed.  Attached.

Please review/push. 

Andrew Bartlett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-param-Consolidate-code-to-enable-smb-signing-on-.patch
Type: text/x-patch
Size: 6542 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131116/4c222784/attachment.bin>


More information about the samba-technical mailing list