[CIFS][PATCH] set copy chunk defaults

David Disseldorp ddiss at suse.de
Fri Nov 15 11:14:14 MST 2013


On Fri, 15 Nov 2013 11:34:18 -0600
Steve French <smfrench at gmail.com> wrote:

> From e53cf824641ad237e1b7ceb09aefbfbfb1787f47 Mon Sep 17 00:00:00 2001
> From: Steve French <smfrench at gmail.com>
> Date: Fri, 15 Nov 2013 11:26:24 -0600
> Subject: [PATCH] [CIFS] Set copychunk defaults
> 
> Patch 2 of the copy chunk series (the final patch will
> use these to handle copies of files larger than the chunk size.
> 
> We set the same defaults that Windows and Samba expect for
> CopyChunk.
> 
> Signed-off-by: Steve French <smfrench at gmail.com>
> ---
>  fs/cifs/cifsglob.h |  3 +++
>  fs/cifs/smb2pdu.c  | 10 +++++++++-
>  2 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index 50a6ca1..d9ea7ad 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -858,6 +858,9 @@ struct cifs_tcon {
>   __le64 vol_create_time;
>   __u32 ss_flags; /* sector size flags */
>   __u32 perf_sector_size; /* best sector size for perf */
> + __u32 max_chunks;
> + __u32 max_bytes_chunk;
> + __u32 max_bytes_copy;

Might be worth prefixing or nesting these to make it clear that they're
copy-chunk specific. Anyhow, looks good as is.

Reviewed-by: David Disseldorp <ddiss at samba.org>

Cheers, David


More information about the samba-technical mailing list