adapt pam_winbin.c to deal with later iniparser versions

Andreas Schneider asn at samba.org
Thu Nov 14 01:49:11 MST 2013


On Thursday 07 November 2013 10:34:26 Noel Power wrote:
> I came across another strange pam related issue with the
> require_membership_of specified flag in pam_winbind.conf with
> opensuse-12.3 ( and possibly earlier versions ) if you have a blank (
> e.g. empty ) value like
> 
>     require_membership_of specified=
> 
> then pam will refuse to authenticate any user
> 
> The problem stems from the fact that we use a different ( later )
> version of iniparser (3.1.5) where the behaviour of iniparser when
> dealing with blank or non-existing key values is different. This patch
> works around the problem ( and although strictly not necessary for
> upstream currently ) and will future proof the code against the eventual
> upgrade of iniparser. Please review

Hi Noel,

thanks for your contribution, but the patch is not sufficient. We have an "in-
tree" copy of iniparser which needs to be updated. Also you probably need to 
check for the function during 'waf configure'. See

lib/iniparser
lib/iniparser_build

I don't really know why we have two directories here ...


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list