[PATCH 2/2] s4:dsdb/rootdse: Support netlogon request
nivanova at samba.org
Mon Nov 11 10:54:10 MST 2013
Looks good to me.
Reviewed-by: nivanova at symas.com
On Fri, Nov 8, 2013 at 7:30 PM, Benjamin Franzke <
benjaminfranzke at googlemail.com> wrote:
> Hi Andrew, hi Nadya,
> Since Andrew reported (on irc) the autobuild-test failure is gone with the
> latest patch,
> I'd like you to review my (hopefully) final version:
> As written in ealierer E-Mails, this is a rewrite of the previous patches
> (which is why i'm asking to review them all),
> since now netlogon may be only one of multiple requested attributes.
> I've also added support for the additional-attribute test over udp,
> and squashed the smaller bug-fixing patches into the main ones.
> I've written the tests against win2k8R2.
> Thanks, Ben
> 2013/11/6 Andrew Bartlett <abartlet at samba.org>
>> On Wed, 2013-11-06 at 12:55 +0100, Benjamin Franzke wrote:
>> > Hi Andrew,
>> > I've read a bit of the nbt code, to see whether I did some wrong
>> guesses or
>> > so,
>> > but then i came to the conclusion maybe the data is invalidated (e.g.
>> > free'd) too early,
>> > before it is actually send out to the client.
>> > That would explain this occasional, hard-to-reproduce error.
>> > Then I found something that *probably* caused that.
>> > I used ldb_msg_add_value to add the netlogon blob to the message:
>> > That means it stays part of requests talloc tree, which may be freed
>> > sending the message(?).
>> > ldb_msg_add_steal_value should be used instead.
>> > I've pushed a patch to my netlogon-8 branch,
>> > could you please run another autobuild to see whether that fixed it?
>> That would certainly do it.
>> I'll re-run the tests.
>> Andrew Bartlett
>> Andrew Bartlett
>> Authentication Developer, Samba Team http://samba.org
More information about the samba-technical